AVM: Switch opcode #4458

algoidurovic · 2022-08-24T19:26:51Z

Adding new switch opcode that contains a variable size list of label references, aka targets. Consumes one integer from the top of the stack A and branches to targets[A].

Test Plan

Assembly and evaluation unit tests.

data/transactions/logic/assembler.go

data/transactions/logic/eval.go

data/transactions/logic/opcodes.go

data/transactions/logic/assembler.go

data/transactions/logic/eval.go

data/transactions/logic/opcodes.go

codecov · 2022-09-09T15:35:04Z

Codecov Report

Merging #4458 (f103b5e) into master (b243e18) will increase coverage by 0.02%.
The diff coverage is 87.09%.

@@            Coverage Diff             @@
##           master    #4458      +/-   ##
==========================================
+ Coverage   55.27%   55.29%   +0.02%     
==========================================
  Files         398      398              
  Lines       50366    50440      +74     
==========================================
+ Hits        27839    27891      +52     
- Misses      20198    20213      +15     
- Partials     2329     2336       +7

Impacted Files	Coverage Δ
data/transactions/logic/doc.go	`61.53% <ø> (ø)`
data/transactions/logic/eval.go	`89.31% <71.42%> (-0.24%)`	⬇️
data/transactions/logic/assembler.go	`85.96% <95.65%> (+0.21%)`	⬆️
data/transactions/logic/opcodes.go	`84.47% <100.00%> (+0.60%)`	⬆️
cmd/algoh/blockWatcher.go	`77.77% <0.00%> (-3.18%)`	⬇️
crypto/merkletrie/trie.go	`66.42% <0.00%> (-2.19%)`	⬇️
agreement/cryptoVerifier.go	`67.60% <0.00%> (-2.12%)`	⬇️
agreement/proposalManager.go	`96.07% <0.00%> (-1.97%)`	⬇️
crypto/merkletrie/node.go	`91.62% <0.00%> (-1.87%)`	⬇️
cmd/tealdbg/debugger.go	`72.69% <0.00%> (-0.81%)`	⬇️
... and 2 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

…ed function

data/transactions/logic/assembler.go

data/transactions/logic/assembler_test.go

data/transactions/logic/eval_test.go

algochoi

PR to generate docs for the new opcode: algoidurovic#2

Moved opcode number to be by other "strange jumps" Added simple tests for normal cases, and for fallthrough Added some overflow protection from handcrafted bytecode by limiting switch labels to 2^16.

…_pr_review Feedback on #3 for switchi fall-through

Made some changes to cast the label count (numOffsets) to `int` sooner. My bug was multiplying numOffsets by 2 while it was still a byte and _then_ casting to int. It had already wrapped.

Allow fall-through in switch

change name to switch. we've agreed next one would be `match`

data/transactions/logic/assembler.go

algoidurovic added 2 commits August 19, 2022 15:05

typo fix

bdc77fe

initial implementation

5683c57

jannotti reviewed Aug 24, 2022

View reviewed changes

jannotti changed the title ~~Switch opcode~~ AVM: Switch opcode Aug 25, 2022

jannotti added the New Feature label Aug 25, 2022

jannotti reviewed Aug 25, 2022

View reviewed changes

data/transactions/logic/assembler.go Outdated Show resolved Hide resolved

jannotti reviewed Aug 25, 2022

View reviewed changes

data/transactions/logic/assembler.go Show resolved Hide resolved

jannotti reviewed Aug 25, 2022

View reviewed changes

data/transactions/logic/eval.go Outdated Show resolved Hide resolved

jannotti reviewed Aug 25, 2022

View reviewed changes

data/transactions/logic/opcodes.go Outdated Show resolved Hide resolved

algoidurovic added 5 commits August 29, 2022 11:41

documentation

80e1b12

respond to feedback

8ebb577

fix errors

011495d

add tests

2ac7890

assemble test

e35f14a

algoidurovic marked this pull request as ready for review September 8, 2022 21:40

algoidurovic added 2 commits September 8, 2022 17:45

resolve merge conflict

5fc4a6a

fix doc formatting and failing test

bf2c849

run make for doc generation, and extract offset decoding into dedicat…

7e6014f

…ed function

jannotti reviewed Sep 9, 2022

View reviewed changes

data/transactions/logic/assembler.go Outdated Show resolved Hide resolved

jannotti reviewed Sep 9, 2022

View reviewed changes

data/transactions/logic/assembler_test.go Outdated Show resolved Hide resolved

data/transactions/logic/eval_test.go Show resolved Hide resolved

algoidurovic added 2 commits September 9, 2022 17:26

touch up

b9b417a

update tests

933df40

algochoi reviewed Sep 14, 2022

View reviewed changes

jannotti and others added 6 commits September 14, 2022 21:24

Allow fall-through in switch

9d1f0de

Moved opcode number to be by other "strange jumps" Added simple tests for normal cases, and for fallthrough Added some overflow protection from handcrafted bytecode by limiting switch labels to 2^16.

Replace hard-coded version with AssemblerMaxVersion in assembler_test.go

c0fa16c

Update docs for switchi fall-through behavior

76b87f5

Add switchi assembly test case

d78965e

Merge pull request algorand#12 from michaeldiamant/switch_fallthrough…

b1aa647

…_pr_review Feedback on #3 for switchi fall-through

Changing encoding to use a single byte for label count

c066ff2

jannotti added 3 commits September 15, 2022 16:56

Fix switch disassembly

d705b0c

Made some changes to cast the label count (numOffsets) to `int` sooner. My bug was multiplying numOffsets by 2 while it was still a byte and _then_ casting to int. It had already wrapped.

docVersion and bump pairing ops

928966a

Merge pull request #3 from jannotti/switch-fallthrough

e88d580

Allow fall-through in switch

jannotti requested review from algochoi and michaeldiamant September 16, 2022 16:37

jannotti added 2 commits September 16, 2022 13:03

change name to switch. we've agreed next one would be match

96fe7c1

Merge pull request #5 from jannotti/switch-name

f103b5e

change name to switch. we've agreed next one would be `match`

algochoi reviewed Sep 16, 2022

View reviewed changes

data/transactions/logic/assembler.go Show resolved Hide resolved

algochoi approved these changes Sep 16, 2022

View reviewed changes

jannotti merged commit 9a604f2 into algorand:master Sep 16, 2022

michaeldiamant mentioned this pull request Sep 19, 2022

AVM 8: Opcode support algorand/pyteal#388

Closed

2 tasks

Algo-devops-service mentioned this pull request Sep 20, 2022

go-algorand 3.10.0-beta Release PR #4565

Merged

onetechnical mentioned this pull request Sep 30, 2022

go-algorand 3.10.0-beta Release PR #4612

Merged

Algo-devops-service mentioned this pull request Sep 30, 2022

go-algorand 3.10.0-stable Release PR #4618

Merged

algoanne mentioned this pull request Nov 1, 2022

go-algorand 3.12.0-beta Release PR #4730

Merged

onetechnical mentioned this pull request Nov 11, 2022

go-algorand 3.12.0-stable Release PR #4783

Closed

onetechnical mentioned this pull request Nov 28, 2022

go-algorand 3.12.2-stable Release PR #4837

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

AVM: Switch opcode #4458

AVM: Switch opcode #4458

algoidurovic commented Aug 24, 2022 •

edited by jannotti

Loading

codecov bot commented Sep 9, 2022 •

edited

Loading

algochoi left a comment

AVM: Switch opcode #4458

AVM: Switch opcode #4458

Conversation

algoidurovic commented Aug 24, 2022 • edited by jannotti Loading

Test Plan

codecov bot commented Sep 9, 2022 • edited Loading

Codecov Report

algochoi left a comment

Choose a reason for hiding this comment

algoidurovic commented Aug 24, 2022 •

edited by jannotti

Loading

codecov bot commented Sep 9, 2022 •

edited

Loading